This repository has been archived by the owner on Jun 2, 2019. It is now read-only.
Remove a few warnings #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black Duck Security ReportMerging #743 into master will not change security risk. |
vikmeup
reviewed
Jun 6, 2018
Trust.xcodeproj/project.pbxproj
Outdated
| @@ -3384,13 +3384,15 @@ | |||
| CLANG_WARN_BOOL_CONVERSION = YES; | |||
| CLANG_WARN_COMMA = YES; | |||
| CLANG_WARN_CONSTANT_CONVERSION = YES; | |||
| CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; | |||
There was a problem hiding this comment.
I assume you meant we don't need this. If so I have made the appropriate changes.
Trust.xcodeproj/project.pbxproj
Outdated
| CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; | ||
| CLANG_WARN_DOCUMENTATION_COMMENTS = YES; | ||
| CLANG_WARN_EMPTY_BODY = YES; | ||
| CLANG_WARN_ENUM_CONVERSION = YES; | ||
| CLANG_WARN_INFINITE_RECURSION = YES; | ||
| CLANG_WARN_INT_CONVERSION = YES; | ||
| CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; | ||
| CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; |
vikmeup
reviewed
Jun 7, 2018
| CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; | ||
| CLANG_WARN_DOCUMENTATION_COMMENTS = YES; | ||
| CLANG_WARN_EMPTY_BODY = YES; | ||
| CLANG_WARN_ENUM_CONVERSION = YES; | ||
| CLANG_WARN_INFINITE_RECURSION = YES; | ||
| CLANG_WARN_INT_CONVERSION = YES; | ||
| CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; | ||
| CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = NO; |
There was a problem hiding this comment.
Are these changes added by Xcode automatically?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A start on removing warnings from the project.