Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed registrar stats for beats >= 6.3 #3

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

anandsinghkunwar
Copy link
Contributor

  • Previously registrar stats writes didn't have subdivisions
    of fail, success and total. In newer version of beats they
    do, adding support for the same.
  • Also adding error details on a log line to help in debugging in
    case of an issue
  • Fixes Beat Exporter Could Not Parse JSON Response for Target #2

* Previously registrar stats writes didn't have subdivisions
  of fail, success and total. In newer version of beats they
  do, adding support for the same.
* Also adding error details on a log line to help in debugging in
  case of an issue
Copy link
Contributor

@shivas shivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivas shivas merged commit 67af338 into trustpilot:master Sep 14, 2018
@shivas
Copy link
Contributor

shivas commented Sep 14, 2018

@anandsinghkunwar thanks, merged and released 0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants