Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Better error message for end users #1100

Closed
wants to merge 1 commit into from
Closed

chore: Better error message for end users #1100

wants to merge 1 commit into from

Conversation

helio-frota
Copy link
Collaborator

Related to #1093

ctron
ctron requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having an appropriate error message is good. But I am not a fan of post-processing messages.

There's a way this message gets created, and we are in full control of this. So we should ensure the message it good from the start.

@helio-frota
Copy link
Collaborator Author

thanks for the review!
I agree 👍

@helio-frota helio-frota deleted the visitor-error-message branch December 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctron ctron ctron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helio-frota @ctron