BUFRSZ too small truncating arc sig #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senders using MS Exchange / Outlook / M365 cloud hosted mail chains many headers together The ARC-Message-Signature body as truncating at 1024 resulting in incomplete ARC headers Unclear which BUFRSZ capped so doubled them all.
flowerysong
pushed a commit
to flowerysong/OpenARC
that referenced
this pull request
Feb 6, 2024
Senders using MS Exchange / Outlook / M365 cloud hosted mail chains many headers together The ARC-Message-Signature body as truncating at 1024 resulting in incomplete ARC headers Unclear which BUFRSZ capped so doubled them all. trusteddomainproject/OpenARC#161
|
Even if the issue is resolved by applying this PR, I don't think the cause of the issue is the value of BUFRSZ, but the wrong size estimation of (a) specific buffer(s). There are other macros for specifying buffer size, ARC_MAXHEADER (in libopenarc/arc.h) and MAXBUFRSZ (in libopenarc/openarc-internal.h and openarc/openarc.h). I guess at least this one should be |
futatuki
added a commit
to futatuki/OpenARC
that referenced
this pull request
Sep 18, 2024
…ate-arc-set-headers As ARC set header may grow up to ARC_MAXHEADER, the limit size per header size we determined to handle, buffer size to store should be larger than it. With this commit, fix a size of the buffer to store header field body. This would fix the problem described in PR trusteddomainproject#161 trusteddomainproject#180
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Senders using MS Exchange / Outlook / M365 cloud hosted mail chains many headers together
The ARC-Message-Signature body as truncating at 1024 resulting in incomplete ARC headers
Unclear which BUFRSZ capped so doubled them all.