Docker Support and INSTALL.md #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason why this did not get merged yet? I think, this is very helpful! |
Closed
|
I'll review your PR and test against OpenARC when doing the next release rollup which is coming up. |
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a dockerfile which provided a domain, selector and private key file will create a CentOS 7 docker running SSH and OpenARC (built from the current source) exposing its default ports (22 and 8894 to allow easier development and testing. I added a docker command to the Makefile to allow easier (re)-creation of the docker, this command deletes the previous running docker, rebuilds the image and recreates the docker.
I also added an INSTALL.md file which contains instructions in how to initially build the project, creating RPMs from it for easier deployment and instructions on how to easily use the docker via Makefile.
These modifications should help solving both #10 and #118.