Fix a buffer overrun in arc_eoh() #117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`strncpy(hnbuf, h->hdr_text, h->hdr_namelen)` assumes that hdr_namelen will never be longer than ARC_MAXHEADER, but that assumption wasn't enforced anywhere. Enforcing the maximum header name length in arc_parse_header_field() seems reasonable, and prevents malformed headers from overrunning this buffer.
|
According to RFC 5322 section 2.1.1. each line of characters MUST be no more than 998 characters, and from the description about field name section 2.2. filed names cannot be folded. So we can use lesser limit value than ARC_MAXHEADER for the restriction |
futatuki
added a commit
to futatuki/OpenARC
that referenced
this pull request
Sep 16, 2024
…eader `strncpy(hnbuf, h->hdr_text, h->hdr_namelen)` assumes that hdr_namelen will never be longer than ARC_MAXHEADER, but that assumption wasn't enforced anywhere. Enforcing the maximum header name length in arc_parse_header_field() seems reasonable, and prevents malformed headers from overrunning this buffer. trusteddomainproject#117
futatuki
added a commit
to futatuki/OpenARC
that referenced
this pull request
Sep 18, 2024
…eader `strncpy(hnbuf, h->hdr_text, h->hdr_namelen)` assumes that hdr_namelen will never be longer than ARC_MAXHEADER, but that assumption wasn't enforced anywhere. Enforcing the maximum header name length in arc_parse_header_field() seems reasonable, and prevents malformed headers from overrunning this buffer. trusteddomainproject#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strncpy(hnbuf, h->hdr_text, h->hdr_namelen)assumes that hdr_namelen will never be longer than ARC_MAXHEADER, but that assumption wasn't enforced anywhere. Enforcing the maximum field name length in arc_parse_header_field() seems reasonable, and prevents malformed headers from overrunning this buffer.