Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ‘use client’ directive syntax #2891

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Apr 18, 2024

Summary

This fixes usage of the package in a React Server Components environment (Next.js app router). This regression was introduced during the Webpack -> Vite migration.

How To Test

  1. npx create-next-app@latest - select Yes for App Router when you get there
  2. Add a React USWDS component to a page

Screenshots

Before

CleanShot 2024-04-17 at 18 09 53@2x

After

CleanShot 2024-04-17 at 18 08 31@2x

@sawyerh sawyerh requested a review from a team as a code owner April 18, 2024 01:10
@sawyerh sawyerh changed the title Fix ‘use client’ directive syntax fix: ‘use client’ directive syntax Apr 18, 2024
@brandonlenz
Copy link
Contributor

@all-contributors please add @sawyerh for bug

@brandonlenz brandonlenz merged commit 4e78d7e into trussworks:main Apr 18, 2024
6 of 7 checks passed
Copy link
Contributor

@brandonlenz

I've put up a pull request to add @sawyerh! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants