Reduce re-exports #161
Draft
Reduce re-exports #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes some wildcard imports to make the dependencies between modules clearer and to refactoring easier.
This patch removes all re-exports of external types as discussed in trussed-dev#155, except for those that are essential for using Trussed: heapless_bytes::Bytes (only from the types module) and littlefs2::path::{Path, PathBuf}. Also, the cbor_smol re-exports in the main module are kept until we have a better mechanism for that. trussed-dev#155
As discussed in trussed-dev#155, this patch removes re-exports from types that are defined inside the crate. This means that all types that are defined in this crate are now only visible under one path. trussed-dev#155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #155, this PR removes most re-exports of external types and all re-exports of internal types. The following re-exports are kept:
heapless_bytes::Bytes(only fromtypes): crucial part of the client APIlittlefs2::path::{Path, PathBuf}: crucial part of the client APIlittlefs2::fs::{DirEntry, Metadata}: also part of the client API, though less importantcbor_smol::{cbor_deserialize, cbor_serialize_bytes}: kept for the time being, but should probably replaced with more specific (de-)serialization methods for the data returned or expected by the API at some pointDepends on: