Make more APIs public #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sosthene-nitrokey
requested review from
nickray,
robin-nitrokey and
daringer
This can be useful for backends which can use it to encode additional information inside of the KeyId itself (128 bits is a lot) This is already possible to acheive through the serde implementation, so this doesn't really add any unavailable functionality.
sosthene-nitrokey
force-pushed
the
pub-key-id
branch
from
61986c0
to
fda94a1
Compare
daringer
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs improve debugging or are required for custom backend implementations.
Built on top of #139 that will need to be merged first.
BackendIdand make itClone. This allows better debugging.KeyIdand reading it. This can already be done through theserdeimplementation. This makes it possible to a custom backend to encode informations so that it can differentiate between keys from thecorebackend and keys it generated itself.