Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restoration of ui status after RequestUserPresence call #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sosthene-nitrokey
Copy link
Contributor

The reply_to method always restores the status to Idle anyway after the syscall returns

Close #129

The `reply_to` method always restores the status to Idle anyway after the syscall returns
@nickray
Copy link
Member

nickray commented Sep 13, 2023

Restoring the status in all cases could work by wrapping the loop in a closure, so we can get the result, always restore status, and only then return.

@sosthene-nitrokey
Copy link
Contributor Author

It would still be overridden by the reply_to method anyway.

@sosthene-nitrokey sosthene-nitrokey requested review from nickray and robin-nitrokey and removed request for nickray September 28, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestUserConsent does not properly restore the ui status when interrupted or timed out.
2 participants