Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestUserConsent does not properly restore the ui status when interrupted or timed out. #129

Open
sosthene-nitrokey opened this issue Jul 19, 2023 · 0 comments · May be fixed by #130
Open

RequestUserConsent does not properly restore the ui status when interrupted or timed out. #129

sosthene-nitrokey opened this issue Jul 19, 2023 · 0 comments · May be fixed by #130

Comments

@sosthene-nitrokey
Copy link
Contributor

In the RequestUserConsent syscall, the ui status is saved, then set to WaitingForUserPresence and finally restored at the end of the call.

However, there are early returns in the loop that cause the restoration to not happen. This is not a very large issue as the call to process restores the status to Idle.
I think the restoration of the status should be removed as it isn't very useful since it is overridden to Idle just after.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove restoration of ui status after RequestUserPresence call sosthene-nitrokey/trussed
1 participant
@sosthene-nitrokey