Extract extensions into crates #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
added a commit
to Nitrokey/trussed-se050-backend
that referenced
this pull request
Mar 13, 2024
Similar to the changes in trussed-staging#19 [0], this patch moves the extension that was previously defined in the backend crate into a separate extension crate. [0] trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/admin-app
that referenced
this pull request
Mar 13, 2024
This patch replaces the dependencies on trussed-staging and trussed-se050-backend with the extension crates trussed-manage and trussed-se050-manage. See the these PRs for more information: - trussed-dev/trussed-staging#19 - Nitrokey/trussed-se050-backend#13
robin-nitrokey
added a commit
to Nitrokey/fido-authenticator
that referenced
this pull request
Mar 13, 2024
This patch adapts to the extraction of the extensions from trussed-staging, see:
trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/opcard-rs
that referenced
this pull request
Mar 13, 2024
This patch adapts to the extraction of extension crates from
trussed-staging, see:
trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/piv-authenticator
that referenced
this pull request
Mar 13, 2024
This patch adapts to the extraction of extension crates from
trussed-staging, see:
trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Mar 13, 2024
This patch replaces the dependencies on trussed-staging and trussed-se050-backend with extension crates extracted from these crates. See the these PRs for more information: - trussed-dev/trussed-staging#19 - Nitrokey/trussed-se050-backend#13
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Mar 13, 2024
This patch replaces the dependencies on trussed-staging and trussed-se050-backend with extension crates extracted from these crates. See the these PRs for more information: - trussed-dev/trussed-staging#19 - Nitrokey/trussed-se050-backend#13
|
Updated based on the comments on Nitrokey/trussed-se050-backend#13. @sosthene-nitrokey Can you please have another look? |
daringer
approved these changes
Mar 15, 2024
sosthene-nitrokey
approved these changes
Mar 15, 2024
Previously, this repository contained one crate with all extension definitions and the backend implementation. This is problematic if semantic versioning is used as a breaking change in the backend or in a single extension would also affect all users of any other extension. This patch moves the extensions into separate crates that can be versioned independently so that clients only have to depend on the extension crates they really need. Fixes: trussed-dev#3
robin-nitrokey
force-pushed
the
extensions
branch
from
5cc6c83
to
06bf42c
Compare
robin-nitrokey
added a commit
to Nitrokey/trussed-se050-backend
that referenced
this pull request
Mar 15, 2024
Similar to the changes in trussed-staging#19 [0], this patch moves the extension that was previously defined in the backend crate into a separate extension crate. [0] trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/trussed-se050-backend
that referenced
this pull request
Mar 15, 2024
Similar to the changes in trussed-staging#19 [0], this patch moves the extension that was previously defined in the backend crate into a separate extension crate. [0] trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/admin-app
that referenced
this pull request
Mar 15, 2024
This patch replaces the dependencies on trussed-staging and trussed-se050-backend with the extension crates trussed-manage and trussed-se050-manage. See the these PRs for more information: - trussed-dev/trussed-staging#19 - Nitrokey/trussed-se050-backend#13
robin-nitrokey
added a commit
to Nitrokey/fido-authenticator
that referenced
this pull request
Mar 15, 2024
This patch adapts to the extraction of the extensions from trussed-staging, see:
trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/opcard-rs
that referenced
this pull request
Mar 15, 2024
This patch adapts to the extraction of extension crates from
trussed-staging, see:
trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/piv-authenticator
that referenced
this pull request
Mar 15, 2024
This patch adapts to the extraction of extension crates from
trussed-staging, see:
trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Mar 15, 2024
This patch replaces the dependencies on trussed-staging and trussed-se050-backend with extension crates extracted from these crates. See the these PRs for more information: - trussed-dev/trussed-staging#19 - Nitrokey/trussed-se050-backend#13
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Mar 15, 2024
This patch replaces the dependencies on trussed-staging and trussed-se050-backend with extension crates extracted from these crates. See the these PRs for more information: - trussed-dev/trussed-staging#19 - Nitrokey/trussed-se050-backend#13
robin-nitrokey
added a commit
to Nitrokey/opcard-rs
that referenced
this pull request
Mar 15, 2024
This patch adapts to the extraction of extension crates from
trussed-staging, see:
trussed-dev/trussed-staging#19
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Mar 22, 2024
This patch replaces the dependencies on trussed-staging and trussed-se050-backend with extension crates extracted from these crates. See the these PRs for more information: - trussed-dev/trussed-staging#19 - Nitrokey/trussed-se050-backend#13
sosthene-nitrokey
pushed a commit
to Nitrokey/opcard-rs
that referenced
this pull request
Apr 22, 2024
This patch adapts to the extraction of extension crates from
trussed-staging, see:
trussed-dev/trussed-staging#19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this repository contained one crate with all extension definitions and the backend implementation. This is problematic if semantic versioning is used as a breaking change in the backend or in a single extension would also affect all users of any other extension.
This patch moves the extensions into separate crates that can be versioned independently so that clients only have to depend on the extension crates they really need.