Remove the dat folders to save littlefs space
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
space-opt-dat
branch
3 times, most recently
from
13b13a2
to
4e06125
Compare
sosthene-nitrokey
force-pushed
the
space-opt-dat
branch
from
5b099dc
to
6827148
Compare
|
I made the migration and the removal of the dat folder optional, so this can be merged without staying a pain having to constantly rebase. |
There was a problem hiding this comment.
I feel like the use_raw configuration option is leaking implementation details. And without context, it is not clear which setting is the “correct”/new one.
What do you think about just using a versioning system? That would make it easy to identify the correct setting, and the implementation details would stay in this crate. Potentially it could also be used to select the correct migration steps.
pub enum FilesystemLayout {
V0,
V1,
}
impl FilesystemLayout {
fn use_raw(&self) -> bool {
self != FilesystemLayout::V0
}
}
Cargo.toml
Outdated
| @@ -20,12 +20,20 @@ serde-byte-array = "0.1.2" | |||
| sha2 = { version = "0.10.6", default-features = false } | |||
| subtle = { version = "2.4.1", default-features = false } | |||
| trussed = { version = "0.1.0", features = ["serde-extensions"] } | |||
| littlefs2 = "0.4.0" | |||
| admin-app = "0.1.0" | |||
There was a problem hiding this comment.
Right admin-app can dev-dependency only.
|
I like that. Will do this. For se050 backend too. |
sosthene-nitrokey
force-pushed
the
space-opt-dat
branch
from
d9b0eb6
to
d9c02b9
Compare
sosthene-nitrokey
force-pushed
the
space-opt-dat
branch
from
d9c02b9
to
b792b18
Compare
robin-nitrokey
added a commit
to robin-nitrokey/trussed-auth
that referenced
this pull request
Apr 2, 2024
The changelog entry for PR trussed-dev#39 ended up in the 0.3.0 section instead of the section for unreleased changes.
robin-nitrokey
added a commit
to robin-nitrokey/trussed-auth
that referenced
this pull request
Apr 3, 2024
The changelog entry for PR trussed-dev#39 ended up in the 0.3.0 section instead of the section for unreleased changes.
robin-nitrokey
added a commit
to robin-nitrokey/trussed-auth
that referenced
this pull request
Apr 3, 2024
The changelog entry for PR trussed-dev#39 ended up in the 0.3.0 section instead of the section for unreleased changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
datfolder used byClientFilestorethat wastes a lot of space on the filesystem.Depends on Nitrokey/trussed#34
This PR also adds a
migratefunction that allows moving from the previous layout to the new layout.The migrate function cannot by itself know if the migration has been done. I would probably have it done by the Admin App, through a "privilegded" syscall, since the admin app is loaded first and can keep track of whether the migration has already been done.