Fix location of data #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary fix until trussed gives us a way to have a per-backend store of data
sosthene-nitrokey
requested review from
robin-nitrokey and
daringer
and removed request for
robin-nitrokey
sosthene-nitrokey
force-pushed
the
store-path
branch
from
9685358
to
1611df6
Compare
sosthene-nitrokey
force-pushed
the
store-path
branch
from
1611df6
to
04497d8
Compare
robin-nitrokey
approved these changes
Apr 5, 2023
Closed
daringer
approved these changes
Apr 5, 2023
|
This does mean that the salt is at |
|
Should we move it to |
|
Let's move the global state to |
|
Current layout: |
| @@ -106,21 +107,21 @@ impl AuthBackend { | |||
|
|
|||
| fn get_global_salt<R: CryptoRng + RngCore>( | |||
| &self, | |||
| trussed_filestore: &mut impl Filestore, | |||
| global_fs: &mut impl Filestore, | |||
| rng: &mut R, | |||
| ) -> Result<Salt, Error> { | |||
| let path = PathBuf::from(BACKEND_DIR).join(&PathBuf::from("salt")); | |||
There was a problem hiding this comment.
Wait, shouldn’t we drop BACKEND_DIR here too?
There was a problem hiding this comment.
Oh right. It's even in the debugdumpstore just above
There was a problem hiding this comment.
Should I do a 0.2.1 or just ovewrite the tag?
There was a problem hiding this comment.
As we already pulled it into nitrokey-3-firmware, let’s use 0.2.1.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix until trussed gives us a way to have a per-backend store of data