Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all status bytes #17

Merged
merged 10 commits into from
Sep 22, 2023
Merged

Conversation

sosthene-nitrokey
Copy link
Contributor

This adds all status bytes defined in ISO7816-4
It also adds an Unknown variant that is #[doc(hidden)] to prevent creation of statuses that exists as a variant.

It also has a const conversion function to allow matching against unsupported status bytes without being a semver hazard.

@sosthene-nitrokey
Copy link
Contributor Author

sosthene-nitrokey commented Sep 15, 2023

  • rename UPPER to MAX
  • rename LOWER to MIN
  • document corresponding values of enum variants
  • make consts and the status module public
  • add const fn to_u16
  • document how to use with unknown status codes.

This adds all status bytes defined in ISO7816-4
It also adds an `Unknown` variant that is `#[doc(hidden)]` to prevent creation of statuses that exists as a variant.

It also has a `const` conversion function to allow matching against unsupported status bytes without being a semver hazard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant