Replace empty maps with an empty response #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sending an empty CBOR map as a response, we now always send an empty response. Previously, we had this as a special case for the ClientPin response, but we need it for LargeBlobs too. So a generic implementation makes more sense and is easier to maintain.
1 task
sosthene-nitrokey
approved these changes
Nov 23, 2023
|
Unfortunately there is no clear rule for that (at least from my understanding), see also the discussion in: Nitrokey/fido-authenticator#6 But it is de facto required both by the Google test suite and the Chrome implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending an empty CBOR map as a response, we now always send an empty response. Previously, we had this as a special case for the ClientPin response, but we need it for LargeBlobs too. So a generic implementation makes more sense and is easier to maintain.