Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pin_protocol field to HmacSecretInput #2

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Add pin_protocol field to HmacSecretInput #2

merged 2 commits into from
Nov 24, 2021

Commits on Nov 4, 2021

  1. Add tests for parsing get_assertion::Parameters 

    The deserialization of authenticatorGetAssertion requests using the
hmac-secret extension as sent by e. g. python-fido2 currently fails.
This patch adds some tests with the offending input.
    @robin-nitrokey
    robin-nitrokey committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    5097fb6 View commit details
    Browse the repository at this point in the history

  2. Add pin_protocol field to HmacSecretInput 

    The December 08, 2020 version of the Client to Authenticator Protocol
(CTAP) specification added the pinUvAuthProtocol(0x04) field to the
input data for the hmac-secret extension in the
authenticatorGetAssertion command.  This patch adds this new field to
the HmacSecretInput struct to make it possible to parse requests using
this new field.
	https://fidoalliance.org/specs/fido-v2.1-rd-20201208/fido-client-to-authenticator-protocol-v2.1-rd-20201208.html

Fixes trussed-dev#1.
    @robin-nitrokey
    robin-nitrokey committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    b341f1b View commit details
    Browse the repository at this point in the history