Add support for iso7816::command::CommandView

CHANGELOG.md

@@ -6,7 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-[Unreleased]: https://github.com/trussed-dev/ctap-types/compare/0.3.0...HEAD
+[Unreleased]: https://github.com/trussed-dev/ctap-types/compare/0.3.1...HEAD
+
+## [0.3.1] 2024-10-18
+
+[0.3.1]: https://github.com/trussed-dev/ctap-types/compare/0.3.0...0.3.1
+
+### Added
+
+- Implement `TryFrom<iso7816::command::CommandView<'a>>` for `Request<'a>`
 
 ## [0.3.0] 2024-08-01
 

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ctap-types"
-version = "0.3.0"
+version = "0.3.1"
 authors = ["Nicolas Stalder <[email protected]>", "The Trussed developers"]
 edition = "2021"
 license = "Apache-2.0 OR MIT"
@@ -42,3 +42,6 @@ log-info = []
 log-debug = []
 log-warn = []
 log-error = []
+
+[patch.crates-io]
+iso7816 = { git = "https://github.com/trussed-dev/iso7816.git", rev = "348238e381108d287204cf2451640882469c9932" }

src/ctap1.rs

@@ -156,8 +156,15 @@ impl Response {
 
 impl<'a, const S: usize> TryFrom<&'a iso7816::Command<S>> for Request<'a> {
     type Error = Error;
-    #[inline(never)]
     fn try_from(apdu: &'a iso7816::Command<S>) -> Result<Request> {
+        apdu.as_view().try_into()
+    }
+}
+
+impl<'a> TryFrom<iso7816::command::CommandView<'a>> for Request<'a> {
+    type Error = Error;
+    #[inline(never)]
+    fn try_from(apdu: iso7816::command::CommandView<'a>) -> Result<Request> {
         let cla = apdu.class().into_inner();
         let ins = match apdu.instruction() {
             iso7816::Instruction::Unknown(ins) => ins,