Revert "Never inline map value deserialization" #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b3ce69. The change has been superseded by Nitrokey#4 = #15 so it was unnecessary to port it to upstream in #16.
sosthene-nitrokey
approved these changes
Oct 8, 2024
daringer
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6b3ce69.
The change has been superseded by Nitrokey#4 = #15 so it was unnecessary to port it to upstream in #16.
Originally, we applied these optimizations to the fork:
When porting the patches to upstream, I applied them in the reverse order:
… and missed that the first patch was actually reverted by the second patch.
See this comment for the numbers: Nitrokey/nitrokey-3-firmware#538 (comment)