add proxy option no_redirect
#859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When serving responses with the Trunk proxy, redirects are automatically followed by default. This can be undesirable, e.g. when serving a login page that response with a redirect and a set-cookie header like ``` HTTP/1.1 303 See Other location: / set-cookie: session=...; ...; ``` This PR adds a proxy option `no_redirect` that when set will instruct the proxy to not automatically follow redirects. The default behavior is unchanged.
ctron
approved these changes
Aug 28, 2024
|
It might be the CI fails because the schema needs to be re-generated: https://github.com/trunk-rs/trunk/blob/main/CONTRIBUTING.md#hacking |
ctron
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving responses with the Trunk proxy, redirects are automatically followed by default. This can be undesirable, e.g. when serving a login page that responds with a redirect and a set-cookie header like
With the default proxy settings, the set-cookie header is simply ignored.
This PR adds a proxy option
no_redirectthat when set will instruct the proxy to not automatically follow redirects. The default behavior is unchanged.