Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

describe truffle test exit code #1197

Merged
merged 1 commit into from
Mar 14, 2022
Merged

describe truffle test exit code #1197

merged 1 commit into from
Mar 14, 2022

Conversation

eggplantzzz
Copy link
Contributor

cds-amal
cds-amal approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@cds-amal cds-amal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. It reminded me that some *nix exit code values are reserved, is that important?

@eggplantzzz
Copy link
Contributor Author

I'm not sure how to answer that, do you mean to ask whether we should return mocha's exit code?

@cds-amal
Copy link
Member

This PR clarifies what we do, and should be documented. What we could return, can be an issue we run by the team.

@eggplantzzz eggplantzzz merged commit 7ebe703 into main Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cds-amal cds-amal cds-amal approved these changes

@tenthirtyone tenthirtyone tenthirtyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eggplantzzz @cds-amal @tenthirtyone