Integrations fully codeowns detectors - #5104
Merged
Merged
Conversation
This includes the injection points of detectors into the rest of the systems. Specifically the detector_type.proto, which is a list of all detectors, and the defaults.go and defaults_test.go (the only contents of pkg/engine/defaults), which are also a list of all detectors.
shahzadhaider1
approved these changes
Jul 2, 2026
martinlocklear
approved these changes
Jul 2, 2026
rajpratham1
approved these changes
Jul 3, 2026
rajpratham1
left a comment
rajpratham1
left a comment
There was a problem hiding this comment.
LGTM. This cleanly updates ownership for detector-related files and keeps the CODEOWNERS configuration consistent. I don't see any issues with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the injection points of detectors into the rest of the systems. Specifically the detector_type.proto, which is a list of all detectors, and the defaults.go and defaults_test.go (the only contents of pkg/engine/defaults), which are also a list of all detectors.
Description:
Right now adding a new detector requires approvals from two teams, and it should really only be one. The integrations teams own detectors, so the attachment points should also be owned by us.
Checklist:
Unrelated to this change, so removed.
Note
Low Risk
Governance-only change to GitHub review routing; no runtime or application code is modified.
Overview
CODEOWNERS now routes detector “registry” touchpoints to @trufflesecurity/integrations alone, so new detectors don’t need scanning review on those paths.
Specifically,
proto/detector_type.protoandpkg/engine/defaults/are owned only by integrations. That overrides the broaderproto/co-ownership and thepkg/engine/scanning rule for those entries—the paths called out in the PR as where detectors are wired into the system (DetectorTypeenum andDefaultDetectorsregistration).Reviewed by Cursor Bugbot for commit 33e85ab. Bugbot is set up for automated code reviews on this repo. Configure here.