Pre-filter GitHub v1 findings to prevent large numbers of validation requests - #4468
Merged
trufflesteeeve merged 1 commit intoSep 18, 2025
Merged
Conversation
martinlocklear
approved these changes
Sep 17, 2025
martinlocklear
left a comment
martinlocklear
left a comment
Contributor
There was a problem hiding this comment.
I think this makes a ton of sense. In one perspective, verification is just another way to filter results, and doing the largest amount of culling early makes sense to me.
kashifkhan0771
approved these changes
Sep 18, 2025
shahzadhaider1
approved these changes
Sep 18, 2025
trufflesteeeve
deleted the
move-github-v1-filtering-before-verification
branch
September 18, 2025 13:53
peterfraedrich
pushed a commit
to peterfraedrich/trufflehog
that referenced
this pull request
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
GitHub v1 tokens are unlikely, so verifying them should only be done if we're relatively confident that the sha256 hash we're seeing isn't actually a sha256 hash.
Checklist:
make test-community)?make lintthis requires golangci-lint)?