Remove prefix regex for JIRA V2 patterns #4197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadhaider1
approved these changes
Jun 2, 2025
amanfcp
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
JIRA V2 tokens start with a unique five-letter prefix (ATATT), yet we're still applying prefixRegex to them. The same applies to associated email addresses pattern. Typically, we don’t apply any prefixRegex when using a standard email pattern, but in this case, we are. This is the main reason the token wasn’t detected in one case for a user.
This pull request remove the use of prefixRegex for JIRA V2 tokens. Given that the pattern is already distinctive and we require three components to generate a valid result, the likelihood of false positives is quite low.
Checklist:
make test-community)?make lintthis requires golangci-lint)?