added lunchmoney scanner #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
reviewed
Apr 20, 2022
| client = common.SaneHttpClient() | ||
|
|
||
| //Make sure that your group is surrounded in boundry characters such as below to reduce false positives | ||
| keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"lunchmoney"}) + `\b([a-zA-Z0-9]{50})\b`) |
There was a problem hiding this comment.
suggestion: tighten this regex and use \b([a-f0-9]{50})\b
There was a problem hiding this comment.
I changed the regex and pushed it. Thanks!
There was a problem hiding this comment.
Some extra context here Mildred, this is a hex-encoded credential which only uses a-f rather than a-z
ahrav
requested changes
Apr 20, 2022
bill-rich
pushed a commit
that referenced
this pull request
May 2, 2022
* added lunchmoney scanner * changed the regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.