[chore] - fix test #3641
Merged
[chore] - fix test #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mcastorina
approved these changes
Nov 21, 2024
|
@ahrav great call. I didn't anticipate the chunks to increase so much with new detectors, but it definitely is acceptable behavior. This fix looks good to me. |
joeleonjr
approved these changes
Nov 21, 2024
kashifkhan0771
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
This is good. I tried to fix it as well in #3646 it worked for some open PR's but not for others. I was wondering what can be the cause.
Since my changes made a conflict in this PR, I resolved them 😃
rosecodym
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the apk handler test by using
GreaterOrEqualinstead ofEqualfor chunk count assertions to accommodate the natural growth of detector keywords as a result of new detectors getting added.Checklist:
make test-community)?make lintthis requires golangci-lint)?