Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Handling of forbidden status in Slack Webhook #3635

Merged

Conversation

abmussani
Copy link
Contributor

Description:

One of the customer reported that they have rotated slack webhook url but detector was throwing error 403 due to not handling of Forbidden status. This PR fix this issue and mark webhook url as unverified if forbidden is being returned.

Checklist:

  • [] Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@abmussani abmussani requested a review from a team as a code owner November 20, 2024 14:20
@rgmz
Copy link
Contributor

rgmz commented Nov 20, 2024

Found unverified result 🐷🔑❓
Verification issue: unexpected HTTP response status 403: invalid_token
Detector Type: SlackWebhook
Decoder Type: PLAIN
Raw result: https://hooks.slack.com/services/T*****/B*****/*****

https://api.slack.com/messaging/webhooks#handling_errors

@zricethezav zricethezav merged commit 6c10a72 into trufflesecurity:main Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants