Compress release with UPX #3456
Merged
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zricethezav
reviewed
Oct 30, 2024
zricethezav
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Compresses the release binary with UPX. On my machine, I had a 48% compression ratio!
I've omitted Darwin because we've seen issues with OSX signing on our Enterprise build when using UPX.
In this PR i've updated the UPX command to allow failure.
I've also changed CI to use the gorelease-pro distribution. That will allow us to parallelize builds later on as well.
Checklist:
make test-community)?make lintthis requires golangci-lint)?