Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Azure now uses a 40 char string as a secret for the service principal instead of 34 chars. Also, even both 34 and 40 char versions used [A-Z] which was missing from the current regex. I don't think there was a need for a v2 detector unless the format for the secret key was changed. This new regex will detect both 40 char and 34 char versions.
See this video for the 34 char version - https://www.youtube.com/watch?v=Kf1Tai_BkWU. At 3:19, it shows that the 34 char version also had [A-Z] in it.
Checklist:
make test-community
)?make lint
this requires golangci-lint)?