Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Detector Regex fix #3271

Closed
wants to merge 1 commit into from
Closed

Azure Detector Regex fix #3271

wants to merge 1 commit into from

Conversation

ankushgoel27
Copy link
Contributor

Description:

Azure now uses a 40 char string as a secret for the service principal instead of 34 chars. Also, even both 34 and 40 char versions used [A-Z] which was missing from the current regex. I don't think there was a need for a v2 detector unless the format for the secret key was changed. This new regex will detect both 40 char and 34 char versions.

See this video for the 34 char version - https://www.youtube.com/watch?v=Kf1Tai_BkWU. At 3:19, it shows that the 34 char version also had [A-Z] in it.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ankushgoel27 ankushgoel27 requested a review from a team as a code owner September 7, 2024 03:23
@rgmz
Copy link
Contributor

rgmz commented Sep 7, 2024

I don't think there was a need for a v2 detector unless the format for the secret key was changed.

The new secrets are substantially different from the old ones. Length, allowed characters, fixed values, etc.

See #2985.

@ankushgoel27
Copy link
Contributor Author

closing this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants