Update HubSpot detectors #2845
Merged
Update HubSpot detectors #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
force-pushed
the
feat/hubspotv1-update
branch
5 times, most recently
from
425fa83 to
2dc1279
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
3 times, most recently
from
f881f05 to
43fc620
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
2 times, most recently
from
c319443 to
307d7d0
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
3 times, most recently
from
b50418d to
1b4ca8a
Compare
|
|
rgmz
force-pushed
the
feat/hubspotv1-update
branch
2 times, most recently
from
af8c7c9 to
1a7e796
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
1a7e796 to
3f73810
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
2 times, most recently
from
aeffc12 to
ab7f4d5
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
ab7f4d5 to
30ace6e
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
30ace6e to
a6edc9e
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
a6edc9e to
7ffd253
Compare
ahrav
reviewed
Nov 7, 2024
| "github.com/kylelemons/godebug/pretty" | ||
|
|
||
| "github.com/trufflesecurity/trufflehog/v3/pkg/detectors" | ||
|
|
There was a problem hiding this comment.
nit: Can we remove this new line in order to group the imports.
There was a problem hiding this comment.
Actually, If this was created using the template file, please disregard my last comment.
There was a problem hiding this comment.
Probably didn't get caught because of the build tags. Can fix it in template + others in another PR.
rgmz
force-pushed
the
feat/hubspotv1-update
branch
3 times, most recently
from
6927d3e to
88e0001
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
88e0001 to
a4714af
Compare
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
a4714af to
b682cce
Compare
feat(hubspot): unify v1 and v2 implementation
rgmz
force-pushed
the
feat/hubspotv1-update
branch
from
b682cce to
81636aa
Compare
ahrav
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This changes the HubSpot v1 detector to tri-state verification and adds two other common keywords.
hubapithe actual domain associated with the HubSpot APIhapikeythe query parameter used to pass in legacy authIt also closes #2369 by merging those changes to align the implementations, and add unit tests to both.
Checklist:
make test-community)?make lintthis requires golangci-lint)?