Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure Detector #1979

Closed
wants to merge 1 commit into from
Closed

Fix Azure Detector #1979

wants to merge 1 commit into from

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 24, 2023 •
edited
Loading

Description:

This PR:

  • Adds support for additional scenarios that I've observed
  • Fixes the verification logic
  • Adds support for partial matches (just client id + client secret can still be valid in many contexts)
  • Dramatically improves the performance of the verification logic when multiple matches are found
  • Adds a dedicated IsKnownFalsePositiveUuid function

I still have more test cases to add, but feedback is welcome at this stage.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner October 24, 2023 21:18
@rgmz rgmz force-pushed the fix/azure-ad branch 6 times, most recently from c4516e3 to ac4b821 Compare October 24, 2023 22:38
@ahrav ahrav added the Hacktoberfest-Detector-Competition-Fix Apply this label if you are fixing a detector for the detector competition label Oct 25, 2023
@rgmz rgmz force-pushed the fix/azure-ad branch 3 times, most recently from 689a585 to f2b6598 Compare October 30, 2023 00:06
@rgmz rgmz marked this pull request as draft October 30, 2023 05:33
@rgmz rgmz mentioned this pull request Jan 4, 2024
Closed
2 tasks
@rgmz rgmz mentioned this pull request Feb 7, 2024
Closed
2 tasks
This was referenced Jun 18, 2024
Merged
Merged
@rgmz rgmz closed this Jun 18, 2024
@rgmz rgmz deleted the fix/azure-ad branch December 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Hacktoberfest-Detector-Competition-Fix Apply this label if you are fixing a detector for the detector competition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @ahrav