NAS-129934 / 24.10 / reset rate limit in client asset for integration tests #13986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Qubad786
approved these changes
Jul 8, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons yet understood, the jenkins pipeline doesn't seem to be reinstalling middleware properly. This meant that the rate limit logic that I added wasn't actually being tested during the CI/CD runs. (I just so happened to be testing manually by hand as well). After a new incremental was generated with the rate limit logic, a large amount of our "roles" related tests failed because they were tripping rate limit.
The
common_checks()function isn't designed very well and is causing an absurd amount ofauth.logincalls during a test run. Instead of trying to fix that, I took path of least resistance and clear the global rate limit cache when we hit it in theclientcontext manager function.