NAS-129929 / 24.10 / Improve SID handling #13984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
anodos325
force-pushed
the
improve-server-sid
branch
11 times, most recently
from
148129c
to
01aeb2b
Compare
Do not rely on Samba to generate a new system SID and make randomized SID persistent across server changes. This is to help prevent admin foot-shooting when they choose to make major server changes that force Samba to regnerate a new SID and thus invalidate their share ACLs. on production servers. Since local user / group RID values are deterministic based on the id key for user / group accounts, populate `sid` key in user.query and group.query extend methods. Apply similar logic to short-circuit SID conversion. The nt_name key provides little value to API consumers and so remove for account entries. Remove subprocess call to `net groupmap` in favor of using our tdb utilities to directly alter the group_mapping.tdb file. This generally performs better and avoids having to synchronize group mappings during group CRUD methods.
anodos325
force-pushed
the
improve-server-sid
branch
from
0793bcb
to
ab6945f
Compare
anodos325
changed the title
mgrimesix
reviewed
Jul 8, 2024
bmeagherix
approved these changes
Jul 9, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not rely on Samba to generate a new system SID and make randomized
SID persistent across server changes. This is to help prevent admin
foot-shooting when they choose to make major server changes that force
Samba to regenrate a new SID and thus invalidate their share ACLs.
on production servers.
Since local user / group RID values are deterministic based on the id
key for user / group accounts, populate
sidkey in user.query andgroup.query extend methods. Apply similar logic to short-circuit
SID conversion.
The nt_name key provides little value to API consumers and so remove
for account entries.
Remove subprocess call to
net groupmapin favor of using our tdbutilities to directly alter the group_mapping.tdb file. This generally
performs better and avoids having to synchronize group mappings during
group CRUD methods.