Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-129920 / 24.10 / jsonrpc server #13979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NAS-129920 / 24.10 / jsonrpc server #13979

wants to merge 1 commit into from

Conversation

themylogin
Copy link
Contributor

No description provided.

@bugclerk
Copy link
Contributor

bugclerk commented Jul 5, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-129920

@bugclerk bugclerk changed the title jsonrpc server NAS-129920 / 24.10 / jsonrpc server Jul 5, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 5, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-129920

@themylogin themylogin force-pushed the jsonrpc branch 3 times, most recently from 2772182 to 5364e85 Compare July 5, 2024 08:02
@anodos325
Copy link
Contributor

Are there any developer docs for this?

@anodos325
Copy link
Contributor

The FreeIPA JSON RPC server provides a principal key in RPC response. It might be nice for API consumers if we provided similarly terse key in response object indicating who operation was performed as.

@themylogin
Copy link
Contributor Author

The FreeIPA JSON RPC server provides a principal key in RPC response. It might be nice for API consumers if we provided similarly terse key in response object indicating who operation was performed as.

What will this non-standard field be useful for? Clients already know if they tried to authorize and whether they did it successfully.

@themylogin themylogin force-pushed the jsonrpc branch 13 times, most recently from cac28a9 to 7316bab Compare July 12, 2024 06:39
@themylogin
Copy link
Contributor Author

HA tests pass: http://jenkins.eng.ixsystems.net:8080/job/master/job/api_tests/1394/

@themylogin themylogin removed the WIP label Jul 12, 2024
@themylogin themylogin requested a review from sonicaj July 12, 2024 10:04
@yocalebo yocalebo requested a review from a team July 12, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yocalebo yocalebo Awaiting requested review from yocalebo

@anodos325 anodos325 Awaiting requested review from anodos325

@sonicaj sonicaj Awaiting requested review from sonicaj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
jira
Projects
None yet
Milestone
No milestone
3 participants
@themylogin @bugclerk @anodos325