Skip to content

fix(external-dns): fix external-dns rbac#37316

Merged
alfi0812 merged 2 commits intotrueforge-org:masterfrom
dennismaxjung:bugfix/external-dns-fix-rbac
Jul 9, 2025
Merged

fix(external-dns): fix external-dns rbac#37316
alfi0812 merged 2 commits intotrueforge-org:masterfrom
dennismaxjung:bugfix/external-dns-fix-rbac

Conversation

@dennismaxjung
Copy link
Copy Markdown
Contributor

@dennismaxjung dennismaxjung commented Jul 9, 2025

Description
Adds EndpointSlices to rbac for use with kubernetes 1.33 (https://kubernetes.io/blog/2025/04/24/endpoints-deprecation/) (kubernetes-sigs/external-dns#5573)
⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code
  • 📜 Documentation Changes

🧪 How Has This Been Tested?

I've tested it on my local cluster by manual expanding the rbac with endpointslices

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made changes to the documentation
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name):, chore(chart-name):, docs(chart-name): or fix(docs):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@alfi0812 alfi0812 merged commit 27905d9 into trueforge-org:master Jul 9, 2025
27 checks passed
@dennismaxjung dennismaxjung deleted the bugfix/external-dns-fix-rbac branch July 10, 2025 13:50
@truecharts-admin
Copy link
Copy Markdown
Contributor

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@trueforge-org trueforge-org locked as resolved and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants