-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] Support for adding resouces to Addons #27351
Comments
It should be for all addons, but yea |
Addons and dependencies need a complete refactor/rewrite, creating a standardized interface for them |
Here's the workaround until addons are reworked, adapted from https://www.talos.dev/v1.8/kubernetes-guides/configuration/device-plugins/. Apply this file to expose /dev/net/tun on your nodes
Verify with Then apply this patch to your broken deployment:
|
This was more of a tracking issue and the above is already on the truecharts.org website. Thanks for trying to help though. |
**Description** This PR updates the add-on system to allow for more end-user flexibility It basically moves add-on container configuration to values.yaml, to expose all container options to end users. Fixes: #27351 Fixes: #31876 **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [ ] 🪛 Bugfix - [ ]⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [ ] ⚖️ My code follows the style guidelines of this project - [ ] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ]⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [ ] ⬆️ I increased versions for any altered app according to semantic versioning - [ ] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Kjeld Schouten <[email protected]> Signed-off-by: Stavros Kois <[email protected]> Co-authored-by: kqmaverick <[email protected]> Co-authored-by: Stavros Kois <[email protected]> Co-authored-by: Stavros Kois <[email protected]>
This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists |
Is your feature request related to a problem?
Talos 1.8 no longer exposes the tunnel interface and it needs to be added as a resource to the vpn container.
https://github.com/siderolabs/talos/releases
Describe the solution you'd like
Add option for addons to include resources like already possible for the main pod
Describe alternatives you've considered
Manually adding the deployment.
Additional context
No response
I've read and agree with the following
The text was updated successfully, but these errors were encountered: