Skip to content

[common] Persisting Tailscale State #27349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
jonaswre opened this issue Dec 16, 2023 · 8 comments · Fixed by #33093
Closed
2 tasks done

[common] Persisting Tailscale State #27349

jonaswre opened this issue Dec 16, 2023 · 8 comments · Fixed by #33093
Assignees
@stavros-k
Labels
enhancement New feature or request
Milestone
backlog

Comments

@jonaswre
Copy link
Contributor

Is your feature request related to a problem?

Im using tailscale to share apps with family and friends. But everytime If I restart the app, tailscale will register as a new device in tailscale and I need to reshare it. I've looked in the source code and the tailscale folder is mounted as emptyDir.

Describe the solution you'd like

I would like for a container to stay the same device in tailscale when restarting the app.

Describe alternatives you've considered

I've found any alternative to keep the device stable.

Additional context

No response

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.
@jonaswre jonaswre added the enhancement New feature or request label Dec 16, 2023
@PrivatePuffin
Copy link
Member

Duplicate of #15911

Keeping this one, as it is indeed a Common issue and not a Charts issue.

@PrivatePuffin PrivatePuffin mentioned this issue Dec 16, 2023
Closed
2 tasks
@PrivatePuffin
Copy link
Member

Same answer though

@delaman
Copy link

delaman commented Dec 16, 2023 •
edited by PrivatePuffin
Loading

Until a proper solution is made. Here is a hack. Requires you to run the following after the truenas scale app is installed.

@PrivatePuffin
Copy link
Member

Sorry, but we have a zero tolerance on hacks and tricks, so it's removed.

We've seen on the iX forums where this leads (lots of bad info, people breaking their stuff etc) and we're not going to condone it within TrueCharts.

@truecharts truecharts locked and limited conversation to collaborators Dec 16, 2023
@truecharts truecharts unlocked this conversation Oct 7, 2024
@PrivatePuffin PrivatePuffin changed the title Persisting Tailscale State [common] Persisting Tailscale State Oct 7, 2024
@PrivatePuffin PrivatePuffin transferred this issue from another repository Oct 7, 2024
@PrivatePuffin PrivatePuffin added this to the backlog milestone Feb 10, 2025
@itconstruct
Copy link
Contributor

I recently noticed this issue has been affecting my tailscale chart and it creates a new device in Tailscale portal. This appears to have occurred when the chart was upgraded.

I added the environment variable hostname: ie with value "home-tailscale" for the device and this has appeared in the Tailscale portal with that specific name.
It's too early to tell if this will persist and keep to the same name when the next chart update occurs but will monitor and report back here with the status.

@PrivatePuffin
Copy link
Member

@itconstruct Feel free to PR this as a default setting if it works for ya!

itconstruct added a commit to itconstruct/truecharts-public that referenced this issue Mar 10, 2025
@itconstruct
Fix for Issue truecharts#27349 - [common] Persisting Tailscaleale State
1b89216
@itconstruct itconstruct mentioned this issue Mar 10, 2025
Merged
13 tasks
@itconstruct
Copy link
Contributor

@itconstruct Feel free to PR this as a default setting if it works for ya!

Tested over the weekend when Tailscale pushed a new update out and state is now persisting and in Tailscale UI the same machine name persists with no additional machines created.
#33093

@alfi0812 alfi0812 linked a pull request Mar 10, 2025 that will close this issue
fix(tailscale) Issue #27349 - [common] Persisting Tailscaleale State #33093
Merged
13 tasks
alfi0812 pushed a commit that referenced this issue Mar 10, 2025
@itconstruct
fix(tailscale) Issue #27349 - [common] Persisting Tailscaleale State (#…
b9d1f97 
…33093)

**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
Tailscale chart updates to cater for Tailscale state not persisting.
This change sets a Tailscale Hostname in the values.yaml file, values to
enable a persistent machine name to apply and to override the default
config of using the kubernetes podname which will change over time and
with upgrades.

⚒️ Fixes  # <!--(issue)-->
#27349 
Tailscale not persisting state

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code
- [x] 📜 Documentation Changes

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->
After applying the hostname value into my helm-release file, an
application update was applied and the hostname persisted in the
Tailscale UI without creating an additional machine.

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [x] 📄 I have made changes to the documentation
- [ ] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):`, `chore(chart-name):`, `docs(chart-name):` or
`fix(docs):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stavros-k stavros-k

Labels
enhancement New feature or request
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

fix(tailscale) Issue #27349 - [common] Persisting Tailscaleale State itconstruct/truecharts-public
6 participants
@itconstruct @delaman @jonaswre @PrivatePuffin @stavros-k @truecharts-admin