should improve console output

trueadm · Mar 10, 2017 · 65f11ee · 65f11ee
1 parent 165bc45
commit 65f11ee
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/scripts/rollup/build.js b/scripts/rollup/build.js
@@ -17,6 +17,7 @@ const {
   replaceInternalModules,
   getFbjsModuleAliases,
   replaceFbjsModuleAliases,
+  getExternalModuleList,
 } = require('./modules');
 const {
   bundles,
@@ -204,9 +205,7 @@ function createBundle({babelOpts, entry, fbEntry, config, paths, name, hasteName
   return rollup({
     entry: bundleType === bundleTypes.FB ? fbEntry : entry,
     plugins: getPlugins(entry, babelOpts, paths, filename, bundleType),
-    external: [
-      'react',
-    ],
+    external: getExternalModuleList(),
   }).then(({write}) => write(
     updateBundleConfig(config, filename, format, bundleType, hasteName)
   )).catch(console.error);

diff --git a/scripts/rollup/modules.js b/scripts/rollup/modules.js
@@ -151,11 +151,26 @@ function replaceFbjsModuleAliases(bundleType) {
   }
 }
 
+function getExternalModuleList() {
+  // this is to stop Rollup spamming the console with warnings
+  return [
+    'react',
+    'warning',
+    'emptyFunction',
+    'emptyObject',
+    'react/lib/ReactCurrentOwner',
+    'react/lib/checkPropTypes',
+    'react/lib/ReactDebugCurrentFrame',
+    'react/lib/ReactComponentTreeHook',
+  ];
+}
+
 module.exports = {
   createModuleMap,
   getExternalModules,
   replaceInternalModules,
   getInternalModules,
   getFbjsModuleAliases,
   replaceFbjsModuleAliases,
+  getExternalModuleList,
 };