Skip to content

[DEVREL-116] Remove unnecessary env switching to determine base URL #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2023
Merged

[DEVREL-116] Remove unnecessary env switching to determine base URL #58

merged 2 commits into from
Apr 12, 2023

Conversation

@zero-bites
Copy link
Contributor

@zero-bites zero-bites commented Apr 6, 2023

Fixes

Removes unnecessary switching between environment URLS

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, create a GitHub Issue in this repository.

@zero-bites zero-bites marked this pull request as ready for review April 6, 2023 15:08
@zero-bites zero-bites merged commit f652976 into dev Apr 12, 2023
@zero-bites zero-bites deleted the DEVREL-116.remove-env-switching branch April 12, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Aman-Aalam Aman-Aalam Aman-Aalam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zero-bites @Aman-Aalam