Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new schema #239

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Feat/new schema #239

merged 2 commits into from
Nov 11, 2024

Conversation

ng-jayson
Copy link
Collaborator

This pull request includes several updates to the hero details and patch notes components in the wiki section, as well as some minor adjustments to other components. The most important changes are focused on improving the user interface and functionality of the hero details component, as well as adding a new message to the patch notes container.

Hero Details Component Improvements:

  • Added a new state selectedRankState to manage the selected rank in the HeroDetails component.
  • Updated the hero image display to include a background image and adjusted image dimensions for better visual presentation.
  • Modified win rate, pick rate, and ban rate calculations to use the selectedRankState for more dynamic data presentation.

Patch Notes Container Update:

  • Added a message informing users about the ongoing updates to the patch notes. [1] [2]

Other Adjustments:

  • Updated the hero card hover effect to scale the image on hover for better visual feedback.
  • Removed unused imports from the heroes-filter.tsx component to clean up the code.
  • Adjusted the tier list container to improve the layout and readability of the tier labels.

@ng-jayson ng-jayson merged commit 8e8fd90 into main Nov 11, 2024
1 check failed
@ng-jayson ng-jayson deleted the feat/new_schema branch November 11, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant