Skip to content

Commit

Permalink
helm-bookmarks: don't change keys to early
Browse files Browse the repository at this point in the history
helm-bookmark-map might not be available yet when helm-mode is enabled, so don't
change bindings until it is available. (fixes a void-variable error)
  • Loading branch information
bmag authored and syl20bnr committed Nov 2, 2017
1 parent 8e1af14 commit f6d4062
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions layers/+completion/helm/packages.el
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@
(helm-locate-set-command)
(setq helm-locate-fuzzy-match (string-match "locate" helm-locate-command))
;; alter helm-bookmark key bindings to be simpler
;; TODO check if there is a more elegant solution to setup these bindings
(defun simpler-helm-bookmark-keybindings ()
(define-key helm-bookmark-map (kbd "C-d") 'helm-bookmark-run-delete)
(define-key helm-bookmark-map (kbd "C-e") 'helm-bookmark-run-edit)
Expand All @@ -136,7 +135,8 @@
(define-key helm-bookmark-map
(kbd "C-o") 'helm-bookmark-run-jump-other-window)
(define-key helm-bookmark-map (kbd "C-/") 'helm-bookmark-help))
(add-hook 'helm-mode-hook 'simpler-helm-bookmark-keybindings)
(with-eval-after-load 'helm-bookmark
(simpler-helm-bookmark-keybindings))
(with-eval-after-load 'helm-mode ; required
(spacemacs|hide-lighter helm-mode)))))

Expand Down

0 comments on commit f6d4062

Please sign in to comment.