-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rake task blows up with ‘Error: No such file - lib/**/*.rb’ #642
Comments
(I’d debug and fix outright, but I’m on vacations and can’t plan my reek time in any way, sorry.) |
Hmm, pretty weird. Adding a binding.pry before here: https://github.com/troessner/reek/blob/master/lib/reek/rake/task.rb#L85 gives me:
which blows up. But if I do a
it works. Investigating... |
I'm guessing the rake task bypasses shell globbing. |
On the road until tomorrow - @mvz do you have time to look into it? I probably cant look into it until tomorrow evening. |
I just did a git bisect:
And look what it found:
Checking out this commit now. |
I considered fixing this pretty urgent since most reek integrations will be using the rake task and this will fail for everybody who upgrades or install reek fresh. What I did:
Aftermath: Let's find out what the problem was with c5c4d07 and re-introduce it. @chastell since you're the author of this commit, would you like to take over? I quickly skimmed it but couldn't see anything obvious. |
I think I found the bug - bugfix is up here: #644 |
Great debugging! It might’ve been a tad easier if the commits were smaller – but, well… ;) Apologies for this; as mentioned in #644 I’ll write tests for |
This reverts commit 864f0a9. Reason for the revert: troessner#642
This reverts commit 864f0a9. Reason for the revert: troessner#642
@troessner I think this issue should be reopened. Rake tasks that customize |
Oh, good point. I think using the setters is a canonical Rake task usage. I’ll fix it early next week at the latest (I’m travelling at the moment). |
I think this is a new bug in reek 3.2 – running
reek
works, runningrake reek
blows up withError: No such file - lib/**/*.rb
. Example from my art_decomp code:The text was updated successfully, but these errors were encountered: