Replace reset_du! => set_zero!, derivative_dhat => derivative_hat#133
Conversation
|
Am I correct in understanding that this shouldn't be merged until after trixi-framework/Trixi.jl#2670 is merged? |
|
I am not 100% sure how we handle these breaking changes. What would make sense to me is that one should merge the change in Trixi first and then adapt here. |
|
Somehow trixi-framework/Trixi.jl#2725 did not cause downstream fails |
DanielDoehring
changed the title
reset_du! with set_zero!reset_du! => set_zero!, derivative_dhat => derivative_hat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 97.10% 97.10%
=======================================
Files 33 33
Lines 4558 4558
=======================================
Hits 4426 4426
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benegee
left a comment
benegee
left a comment
There was a problem hiding this comment.
Thanks a lot for taking care!
The Trixi.jl downstream tests currently executes just one elixir, which does not cover the covariant solver part.
…hat` (trixi-framework#133) * Replace `reset_du!` with `set_zero!` * Replace reset_du! with set_zero! for du * require v0.14 of Trixi.jl * bump trixi test project toml * derivative_hat --------- Co-authored-by: Tristan Montoya <montoya.tristan@gmail.com> Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
4 participants
See trixi-framework/Trixi.jl#2670