Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
From |
|
I need to investigate why I am getting: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
- Coverage 97.07% 96.75% -0.33%
==========================================
Files 610 612 +2
Lines 47500 47531 +31
==========================================
- Hits 46110 45985 -125
- Misses 1390 1546 +156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ranocha
left a comment
There was a problem hiding this comment.
Can you please add a (brief) section to the documentation, e.g., https://trixi-framework.github.io/TrixiDocumentation/stable/performance/, describing how to use these tools for benchmarking (or at least mentioning that Trixi.jl supports them and linking to other docs for further information)?
… VTune Delay init of domain fixup: formatting add color
|
Please request my review when you've finished this PR. |
For GPU-accelerated development we often use external profilers, such as NSight System.
With this PR we automatically annotate and then get inside NSight System: