More verbose namings GPU adds#2899
More verbose namings GPU adds#2899DanielDoehring wants to merge 1 commit intotrixi-framework:mainfrom
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 609 609
Lines 47484 47484
=======================================
Hits 46102 46102
Misses 1382 1382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| mesh_type::Type{<:Union{P4estMesh{2}, | ||
| P4estMeshView{2}, | ||
| T8codeMesh{2}}}, |
There was a problem hiding this comment.
We used MeshT in many other places instead. Could you please unify this?
(I think @sloede suggested MeshT, correct?)
| have_nonconservative_terms, | ||
| equations, surface_integral, | ||
| st::Type{<:DG}, u_interface, | ||
| solver_type::Type{<:DG}, u_interface, |
There was a problem hiding this comment.
This could be SolverT to mimic MeshT.
|
Can we close this given that #2901 has been merged? |
|
Yes! |
I think
stis really not obvious that it is connected todg.mtis changed as well for consistency