volume_integral_kernel! for DGMulti#2809
volume_integral_kernel! for DGMulti#2809DanielDoehring merged 5 commits intotrixi-framework:mainfrom
volume_integral_kernel! for DGMulti#2809Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2809 +/- ##
==========================================
+ Coverage 97.09% 97.10% +0.01%
==========================================
Files 589 589
Lines 45536 45539 +3
==========================================
+ Hits 44211 44218 +7
+ Misses 1325 1321 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jlchan
left a comment
There was a problem hiding this comment.
Thanks for refactoring this!
| # interpolate to quadrature points | ||
| apply_to_each_field(mul_by!(rd.Vq), u_values, u) |
There was a problem hiding this comment.
Isn't this now called for every element, making it much more expensive?
There was a problem hiding this comment.
Oh yeah absolutely right. I opened a fix: #2812
There was a problem hiding this comment.
Can't believe I missed that...
| # interpolate to quadrature points | ||
| apply_to_each_field(mul_by!(rd.Vq), u_values, u) |
* start * fmt * fmt
See #2802 (comment)