`VolumeIntegralAdaptive` with `IndicatorEntropyChange` by DanielDoehring · Pull Request #2754 · trixi-framework/Trixi.jl

DanielDoehring · 2026-01-20T20:52:23Z

Carved out from #2601 . Currently very similar to #468 and #2764

…ixi.jl into VolumeIntegralAdaptive

…ing/Trixi.jl into VolumeIntegralAdaptive_Start

src/callbacks_step/analysis_dg2d.jl

src/solvers/dgsem/indicators.jl

src/solvers/dg.jl

examples/tree_2d_dgsem/elixir_euler_density_wave_adaptive_vol_int.jl

ranocha · 2026-02-13T07:39:25Z

examples/tree_2d_dgsem/elixir_euler_kelvin_helmholtz_instability_adaptive_vol_int.jl

+###############################################################################
+# run the simulation
+
+sol = solve(ode, CarpenterKennedy2N54(williamson_condition = false);


Would it make sense to switch to SSPRK43 here from your point of view?

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

DanielDoehring · 2026-02-13T08:48:45Z

src/solvers/dg.jl

+    VolumeIntegralAdaptive(;
+                           volume_integral_default,
+                           volume_integral_stabilized,
+                           indicator = IndicatorEntropyChange())
+
+!!! warning "Experimental code"
+    This code is experimental and may change in any future release.
+
+Currently limited to `IndicatorEntropyChange()`.
+"""
+struct VolumeIntegralAdaptive{VolumeIntegralDefault, VolumeIntegralStabilized,
+                              Indicator} <: AbstractVolumeIntegral
+    volume_integral_default::VolumeIntegralDefault # Cheap(er) default volume integral to be used in non-critical regions
+    volume_integral_stabilized::VolumeIntegralStabilized # More expensive volume integral with stabilizing effect
+    indicator::Indicator
+end


This new version should also work for you @jlchan, right? we would then dispatch calc_volume_integral only on the indicator and could keep the stuff related to volume integrals fully general.

Yes! I actually also made the change recently in

Trixi.jl/src/solvers/dg.jl

Lines 309 to 315 in 97504dd

struct VolumeIntegralEntropyCorrection{VolumeIntegralDefault,

VolumeIntegralEntropyStable, Indicator} <:

AbstractVolumeIntegralShockCapturing

volume_integral_default::VolumeIntegralDefault

volume_integral_entropy_stable::VolumeIntegralEntropyStable

indicator::Indicator

end

Happy to unify things under VolumeIntegralAdaptive when it's ready.

ranocha

Thanks, this looks already quite good to me 👍

src/solvers/dg.jl

src/solvers/dgsem/calc_volume_integral.jl

ranocha · 2026-02-13T14:46:21Z

Please also note #2754 (comment)

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

…ing/Trixi.jl into VolumeIntegralAdaptive_Start

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

ranocha

Thanks a lot! I will merge this, assuming you add a bit of documentation explaining what the volume integral does in a subsequent PR.

…rk#2754) * Make volume integral computation adaptive * towards 2d * simplify * towards 2d * try * non cons does not work with weak form * example * whiteapce * vis * Compute first mean, then entropy (much cheaper) * move u mean * benchmark * comment * work * u_mean * rm * fmt * shorten * work * shorten * shorten * move * bt * examples * restz * todo * rename * test * fmt * rm amr cap * covergae * SAVE Sol * ex * test vals * Update test/test_tree_1d_euler.jl * Update test/test_tree_1d_euler.jl * rm int * Update src/solvers/dgsem/calc_volume_integral.jl Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> * rev * rev * better indicator * prototype * ft * fmt * rm * 3d test * cont * rename * more examples * cont * Update src/solvers/dgsem/dgsem.jl * Update src/solvers/dgsem_tree/indicators.jl * 3d non std * alive cb * incr * clean up * shorten * tests * WF & SC * ac * 12.5 * restruct * fix * test more print * Update src/solvers/dgsem_tree/indicators.jl * Update src/solvers/dgsem_tree/indicators.jl * Update src/solvers/dgsem_tree/indicators.jl * safety check * Update src/solvers/dgsem_tree/indicators.jl * Update src/solvers/dg.jl * change * change * jacobian * use negative matrix * investigate * hllc * jac business * move indicator * more indicators * docstrings, test * experiment threshold adjustment * try clever update of target entropy decay * rm example * storage-computation tradeoff * store entropy * 3d sedov blast * all reference * update * Adaptive & RRG * update target decay * idea * try update again * float * params * naca0012 NSF separation * use sd7003 for separation example * restart * fi xorder cbs * rm save sol * restart * add * run longer non-ref * rev * check with AMR 3 * remove `calc_entropy_delta`: Trade computations for storage * rm update * 2 lvl indicator * change * toml * rm * conclude sd7003 sim * compare runtimes * rename * reduce to entropy diffusion * linear stab * reference * fix * test vals * Update src/callbacks_step/analysis_dg2d.jl Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> * comments * Update src/solvers/dgsem/calc_volume_integral.jl Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> * safe guarding * comment * cfl * rename * make more similar to Jessse PR * move comment * fix * fix * comments * adapt to jesse info * docstrings * fix * export * rename * fix * fix * comment * Update src/solvers/dgsem/indicators.jl Co-authored-by: Jesse Chan <1156048+jlchan@users.noreply.github.com> * retrieve * exchange * Update src/equations/compressible_euler_2d.jl * ii => i * bcs * mesh periodi * move create cache * Apply suggestions from code review Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> * Fix * rm defaults * generalize comments * comments * format * Update src/solvers/dg.jl Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> * change * Update src/solvers/dg.jl Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> --------- Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com> Co-authored-by: Jesse Chan <1156048+jlchan@users.noreply.github.com> Co-authored-by: Hendrik Ranocha <mail@ranocha.de>

DanielDoehring and others added 30 commits July 20, 2025 19:05

Make volume integral computation adaptive

f355e1b

Merge branch 'main' into VolumeIntegralAdaptive

552d717

towards 2d

3ca63fc

simplify

147e896

towards 2d

2eec5d8

try

8e9949b

non cons does not work with weak form

d823ff5

example

7bc660a

whiteapce

fc0347a

vis

724335a

Compute first mean, then entropy (much cheaper)

3166699

move u mean

c0b1f0b

benchmark

9876f85

Merge branch 'VolumeIntegralAdaptive' of github.com:DanielDoehring/Tr…

dde3c81

…ixi.jl into VolumeIntegralAdaptive

comment

6ec9287

work

a96827b

u_mean

004adba

rm

7409fdb

fmt

0bec762

shorten

e7ae7a2

work

32e4c75

Merge branch 'main' into VolumeIntegralAdaptive

0a38976

shorten

1375fa7

shorten

64c123a

move

0dac510

bt

58db43b

examples

5f885d6

restz

224b84d

todo

eaefcc1

rename

e27d62a

DanielDoehring and others added 7 commits February 8, 2026 16:12

ii => i

3fdc40b

Merge branch 'main' into VolumeIntegralAdaptive_Start

a6ee470

bcs

fab3586

Merge branch 'VolumeIntegralAdaptive_Start' of github.com:DanielDoehr…

d77d215

…ing/Trixi.jl into VolumeIntegralAdaptive_Start

mesh periodi

3681cdf

Merge branch 'main' into VolumeIntegralAdaptive_Start

d3d8ac0

move create cache

62b4d29

ranocha requested changes Feb 13, 2026

View reviewed changes

DanielDoehring and others added 3 commits February 13, 2026 09:17

Apply suggestions from code review

6d937bf

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

Fix

971402c

rm defaults

76679b9

DanielDoehring commented Feb 13, 2026

View reviewed changes

DanielDoehring and others added 4 commits February 13, 2026 09:49

Merge branch 'main' into VolumeIntegralAdaptive_Start

428f959

generalize comments

6616bfa

comments

61a59ac

format

d7704b7

ranocha requested changes Feb 13, 2026

View reviewed changes

src/solvers/dg.jl Show resolved Hide resolved

src/solvers/dg.jl Outdated Show resolved Hide resolved

src/solvers/dgsem/calc_volume_integral.jl Outdated Show resolved Hide resolved

DanielDoehring and others added 4 commits February 13, 2026 17:11

Update src/solvers/dg.jl

85e6cc1

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

change

79dd955

Merge branch 'VolumeIntegralAdaptive_Start' of github.com:DanielDoehr…

e1c0d66

…ing/Trixi.jl into VolumeIntegralAdaptive_Start

Update src/solvers/dg.jl

d88ef7b

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

ranocha approved these changes Feb 13, 2026

View reviewed changes

ranocha merged commit 9f4f60a into trixi-framework:main Feb 13, 2026
39 checks passed

DanielDoehring deleted the VolumeIntegralAdaptive_Start branch February 13, 2026 23:06

DanielDoehring mentioned this pull request Feb 17, 2026

Different volume integrals within one simulation #2472

Closed

This was referenced Feb 22, 2026

Refactor subcell_limiting_kernel! => volume_integral_kernel! #2821

Merged

WIP: ES volume integral #468

Closed

DanielDoehring mentioned this pull request Mar 8, 2026

Adaptive Volume Integral for DGMulti: WF & FD, Polynomial() & Affine #2850

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`VolumeIntegralAdaptive` with `IndicatorEntropyChange`#2754

`VolumeIntegralAdaptive` with `IndicatorEntropyChange`#2754
ranocha merged 200 commits intotrixi-framework:mainfrom
DanielDoehring:VolumeIntegralAdaptive_Start

DanielDoehring commented Jan 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ranocha Feb 13, 2026

Uh oh!

DanielDoehring Feb 13, 2026

Uh oh!

jlchan Feb 13, 2026 •

edited

Loading

Uh oh!

ranocha left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ranocha commented Feb 13, 2026

Uh oh!

ranocha left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	struct VolumeIntegralEntropyCorrection{VolumeIntegralDefault,
	VolumeIntegralEntropyStable, Indicator} <:
	AbstractVolumeIntegralShockCapturing
	volume_integral_default::VolumeIntegralDefault
	volume_integral_entropy_stable::VolumeIntegralEntropyStable
	indicator::Indicator
	end

Conversation

DanielDoehring commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ranocha Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

DanielDoehring Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

jlchan Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ranocha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ranocha commented Feb 13, 2026

Uh oh!

ranocha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DanielDoehring commented Jan 20, 2026 •

edited

Loading

jlchan Feb 13, 2026 •

edited

Loading