Skip to content

Remove boundary_interpolation matrix for DGSEM#2741

Merged
ranocha merged 38 commits intotrixi-framework:mainfrom
DanielDoehring:BoundaryInterpolationMatrix
Jan 23, 2026
Merged

Remove boundary_interpolation matrix for DGSEM#2741
ranocha merged 38 commits intotrixi-framework:mainfrom
DanielDoehring:BoundaryInterpolationMatrix

Conversation

@DanielDoehring
Copy link
Copy Markdown
Member

Follows discussion in #2725

This PR primarily aims at eliminating unnecessary datastructures to make the DGSEM methodology more clear.
Maybe this comes also with performance benefits, but that is not 100% clear (see #2725 (comment) )

@DanielDoehring DanielDoehring requested a review from jlchan January 18, 2026 09:23
@github-actions
Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@DanielDoehring DanielDoehring added discussion low-priority refactoring Refactoring code without functional changes labels Jan 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.03%. Comparing base (12f9642) to head (4fe577c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
+ Coverage   95.65%   97.03%   +1.38%     
==========================================
  Files         569      569              
  Lines       44466    44456      -10     
==========================================
+ Hits        42531    43136     +605     
+ Misses       1935     1320     -615     
Flag Coverage Δ
unittests 97.03% <100.00%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielDoehring DanielDoehring marked this pull request as ready for review January 22, 2026 13:31
@DanielDoehring DanielDoehring changed the title Boundary interpolation matrix Remove boundary_interpolation matrix for DGSEM Jan 22, 2026
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha enabled auto-merge (squash) January 23, 2026 12:41
@ranocha ranocha merged commit 0d75cb4 into trixi-framework:main Jan 23, 2026
39 checks passed
@DanielDoehring DanielDoehring deleted the BoundaryInterpolationMatrix branch January 23, 2026 13:19
DanielDoehring added a commit to DanielDoehring/Trixi.jl that referenced this pull request Feb 19, 2026
)

* explain dhat

* comment boundary matrix

* comments

* rev

* comments

* rename

* comment

* comments

* update

* comment

* compress boundary matrix

* rev

* rm comment

* one factor

* pcom

* bf

* fmt

* bf

* rename

* test

* pm

* comm

* factor

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discussion low-priority refactoring Refactoring code without functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants