Skip to content

Add 3d subcell limiting example with nonconservative terms#2688

Merged
bennibolm merged 9 commits intotrixi-framework:mainfrom
bennibolm:3d-subcell-nonconservative-terms
Jan 7, 2026
Merged

Add 3d subcell limiting example with nonconservative terms#2688
bennibolm merged 9 commits intotrixi-framework:mainfrom
bennibolm:3d-subcell-nonconservative-terms

Conversation

@bennibolm
Copy link
Copy Markdown
Contributor

Add 3d subcell limiting support for nonconservative terms of type NonConservativeSymmetric.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2025

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 99.57983% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.01%. Comparing base (dc2966b) to head (08e2ef5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/equations/ideal_glm_mhd_3d.jl 97.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
+ Coverage   97.00%   97.01%   +0.02%     
==========================================
  Files         555      556       +1     
  Lines       43723    43958     +235     
==========================================
+ Hits        42410    42645     +235     
  Misses       1313     1313              
Flag Coverage Δ
unittests 97.01% <99.58%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bennibolm bennibolm added the enhancement New feature or request label Dec 4, 2025
@bennibolm bennibolm marked this pull request as ready for review December 4, 2025 13:59
@bennibolm bennibolm requested a review from amrueda December 4, 2025 15:31
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
DanielDoehring
DanielDoehring previously approved these changes Dec 8, 2025
Copy link
Copy Markdown
Member

@DanielDoehring DanielDoehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from software-engineering viewpoint

DanielDoehring
DanielDoehring previously approved these changes Dec 9, 2025
@bennibolm bennibolm mentioned this pull request Jan 5, 2026
12 tasks
amrueda
amrueda previously approved these changes Jan 7, 2026
Copy link
Copy Markdown
Contributor

@amrueda amrueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks, @bennibolm!
Some minor comments below.

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>
@bennibolm bennibolm dismissed stale reviews from amrueda and DanielDoehring via 891e22b January 7, 2026 11:46
@bennibolm bennibolm enabled auto-merge (squash) January 7, 2026 18:15
@bennibolm bennibolm merged commit a499f99 into trixi-framework:main Jan 7, 2026
39 checks passed
@bennibolm bennibolm deleted the 3d-subcell-nonconservative-terms branch January 8, 2026 08:22
DanielDoehring added a commit to DanielDoehring/Trixi.jl that referenced this pull request Feb 19, 2026
…mework#2688)

* Add example with nonconservative terms of type `NonConservativeSymmetric`

* Decrease outer pressure to actually use positivity limiting for pressure

* Apply suggestions from code review

Co-authored-by: Daniel Doehring <doehringd2@gmail.com>

* Remove `fhat` resets in new function

* Apply suggestions from code review

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>

---------

Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants