Add 3d subcell limiting example with nonconservative terms#2688
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
+ Coverage 97.00% 97.01% +0.02%
==========================================
Files 555 556 +1
Lines 43723 43958 +235
==========================================
+ Hits 42410 42645 +235
Misses 1313 1313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
DanielDoehring
left a comment
There was a problem hiding this comment.
LGTM from software-engineering viewpoint
amrueda
left a comment
There was a problem hiding this comment.
LGTM!
Thanks, @bennibolm!
Some minor comments below.
Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>
…mework#2688) * Add example with nonconservative terms of type `NonConservativeSymmetric` * Decrease outer pressure to actually use positivity limiting for pressure * Apply suggestions from code review Co-authored-by: Daniel Doehring <doehringd2@gmail.com> * Remove `fhat` resets in new function * Apply suggestions from code review Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de> --------- Co-authored-by: Daniel Doehring <doehringd2@gmail.com> Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de> Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>
Add 3d subcell limiting support for nonconservative terms of type
NonConservativeSymmetric.