Skip to content

only one PR for GitHub actions updates#2681

Merged
ranocha merged 4 commits intomainfrom
hr/update_dependabot
Dec 3, 2025
Merged

only one PR for GitHub actions updates#2681
ranocha merged 4 commits intomainfrom
hr/update_dependabot

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Dec 2, 2025

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

JoshuaLampert
JoshuaLampert previously approved these changes Dec 2, 2025
View reviewed changes
@ranocha ranocha enabled auto-merge (squash) December 2, 2025 09:18
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.85%. Comparing base (fee6f96) to head (e0a3660).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2681   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files         546      546           
  Lines       43276    43276           
=======================================
  Hits        41914    41914           
  Misses       1362     1362
Flag Coverage Δ
unittests 96.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoshuaLampert
Copy link
Copy Markdown
Member

JoshuaLampert commented Dec 2, 2025

We should probably ignore updates to the downgrade action, see #2507. Currently experimenting with this in NumericalMathematics/DispersiveShallowWater.jl#271.

andrewwinters5000
andrewwinters5000 reviewed Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will make the updates at the beginning of the month much more streamlined.

@ranocha ranocha requested a review from JoshuaLampert December 2, 2025 11:53
@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Dec 2, 2025

We should probably ignore updates to the downgrade action, see #2507. Currently experimenting with this in NumericalMathematics/DispersiveShallowWater.jl#271.

Good point! I updated the PR accordingly.

@ranocha ranocha disabled auto-merge December 2, 2025 11:55
@ranocha ranocha enabled auto-merge (squash) December 2, 2025 11:55
JoshuaLampert
JoshuaLampert requested changes Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring julia-downgrade-compat doesn't seem to work like this, see NumericalMathematics/DispersiveShallowWater.jl#272. I'll try to figure out why.

JoshuaLampert
JoshuaLampert requested changes Dec 2, 2025
View reviewed changes
@ranocha @JoshuaLampert
Update .github/dependabot.yml
9b9eec8 
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@ranocha ranocha requested a review from JoshuaLampert December 2, 2025 15:22
JoshuaLampert
JoshuaLampert approved these changes Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sloede sloede mentioned this pull request Dec 2, 2025
Open
@ranocha ranocha disabled auto-merge December 3, 2025 06:56
@ranocha ranocha merged commit 734c93b into main Dec 3, 2025
63 of 66 checks passed
@ranocha ranocha deleted the hr/update_dependabot branch December 3, 2025 06:56
@svchb svchb mentioned this pull request Dec 8, 2025
Merged
efaulhaber
efaulhaber reviewed Dec 10, 2025
View reviewed changes
docs/make.jl
Comment on lines +185 to +188
# Only push previews if all the relevant environment variables are non-empty.
push_preview = all(!isempty,
(get(ENV, "GITHUB_TOKEN", ""),
get(ENV, "DOCUMENTER_KEY", ""))))
Copy link
Copy Markdown
Member

@efaulhaber efaulhaber Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does this do? In which cases does it prevent pushing previews?

Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See JuliaDocs/Documenter.jl#2048.

DanielDoehring pushed a commit to DanielDoehring/Trixi.jl that referenced this pull request Feb 19, 2026
@ranocha @JoshuaLampert @DanielDoehring
only one PR for GitHub actions updates (trixi-framework#2681)
45aca1f 
* only one PR for GitHub actions updates

* Ignore julia-downgrade-compat dependency updates

* Update .github/dependabot.yml

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

---------

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewwinters5000 andrewwinters5000 andrewwinters5000 left review comments

@efaulhaber efaulhaber efaulhaber left review comments

@JoshuaLampert JoshuaLampert JoshuaLampert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ranocha @JoshuaLampert @andrewwinters5000 @efaulhaber